fix segment hit #58
fix segment hit #58
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the segment hit tracking by converting all persona values to strings and includes a version bump to 4.2.1-beta. However, the PR introduces a critical bug in the default_strategy.dart file where JSON encoding results are not being assigned to variables.
Key Changes:
- Converts persona map values to strings in the Segment hit's
bodyTrackmethod to ensure proper serialization - Adds error handling for JSON encoding in the visitor exposure callback (though implementation is buggy)
- Updates SDK version to 4.2.1-beta
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumps package version to 4.2.1-beta |
| lib/visitor/strategy/default_strategy.dart | Adds try-catch for JSON encoding of exposure data, but fails to assign encoded values |
| lib/hits/segment.dart | Converts persona values to strings and fixes typo in comment |
| lib/flagship_version.dart | Updates version constant to 4.2.1-beta |
| example/lib/Providers/fs_data.dart | Adds test context data with various types including an incorrect Null value |
| CHANGELOG.md | Documents the persona string conversion fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.2.0-beta #58 +/- ##
==============================================
- Coverage 77.60% 77.54% -0.06%
==============================================
Files 67 67
Lines 2867 2864 -3
==============================================
- Hits 2225 2221 -4
- Misses 642 643 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
No description provided.